Skip to content

[SDK] expose getUserOpHash utility function #6424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

[SDK] expose getUserOpHash utility function #6424

merged 1 commit into from
Mar 6, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 5, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the signMessage functionality across several components in the thirdweb wallet library, while introducing a new utility function getUserOpHash for hashing user operations.

Detailed summary

  • Added getUserOpHash function to hash user operations.
  • Modified signMessage in wallet.ts to accept originalMessage and chainId.
  • Updated signMessage in sign-message.enclave.ts to include new parameters.
  • Altered signMessage in enclave-wallet.ts to handle additional data.
  • Adjusted signUserOp to utilize getUserOpHash and pass new parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 9:32pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 9:32pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 9:32pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 9:32pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 9:32pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 5, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review March 5, 2025 21:22
@joaquim-verges joaquim-verges requested review from a team as code owners March 5, 2025 21:22
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Mar 5, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 157 ms (+172.66% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 244 ms (+33.12% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+1515.38% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 24 ms (+1242.54% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 74 ms (+421.85% 🔺) 460 ms

@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (d753201) to head (7c81e30).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 0.00% 4 Missing ⚠️
...allets/in-app/core/actions/sign-message.enclave.ts 0.00% 3 Missing ⚠️
packages/thirdweb/src/wallets/smart/lib/userop.ts 89.65% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6424   +/-   ##
=======================================
  Coverage   54.61%   54.62%           
=======================================
  Files         874      874           
  Lines       54723    54743   +20     
  Branches     3710     3713    +3     
=======================================
+ Hits        29886    29902   +16     
- Misses      24742    24746    +4     
  Partials       95       95
Flag Coverage Δ
packages 54.62% <72.22%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...allets/in-app/core/actions/sign-message.enclave.ts 7.14% <0.00%> (-0.36%) ⬇️
packages/thirdweb/src/wallets/smart/lib/userop.ts 74.04% <89.65%> (+0.70%) ⬆️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 6.41% <0.00%> (-0.07%) ⬇️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 38ae2d3 into main Mar 6, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_expose_getUserOpHash_utility_function branch March 6, 2025 01:08
@joaquim-verges joaquim-verges mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges